Cleanup src/deps

Forum closed. All further discussion to be discussed at https://github.com/OpenKore/

Moderators: Moderators, Developers

EternalHarvest
Developers
Developers
Posts: 1798
Joined: 05 Dec 2008, 05:42
Noob?: Yes

Cleanup src/deps

#1 Post by EternalHarvest »

Everything in src/deps which is not patched in some way should be removed. Windows binary should be updated accordingly.
User avatar
kLabMouse
Administrator
Administrator
Posts: 1301
Joined: 24 Apr 2008, 12:02

Re: Cleanup src/deps

#2 Post by kLabMouse »

EternalHarvest wrote:Everything in src/deps which is not patched in some way should be removed. Windows binary should be updated accordingly.
Why??? O_o
That src/deps was made to make OpenKore more portable.
EternalHarvest
Developers
Developers
Posts: 1798
Joined: 05 Dec 2008, 05:42
Noob?: Yes

Re: Cleanup src/deps

#3 Post by EternalHarvest »

Modules in deps may:
- be Perl core modules (Text::Balanced)
- have faster XS versions (List::MoreUtils)
- have their own bug fixes

It's fine to provide them in some supplementary download in case there's Perl, but no working CPAN for some reason, but aside Windows (it has its own executable with all the stuff anyway) where such situation commonly arise?
User avatar
kLabMouse
Administrator
Administrator
Posts: 1301
Joined: 24 Apr 2008, 12:02

Re: Cleanup src/deps

#4 Post by kLabMouse »

'deps' there was for some reason.
there where modules that are needed for OpenKore to work.
Anyway, thus modules that are not included in standard Perl distro must go there.