XKore Proxy mode and sync packets

[Empyrium]

Hey,

I just scanned the code of Network::XKoreProxy and noticed that in modifyPacketOut the sync packets coming from the client are blocked. Afterwards $messageSender->sendSync() is called but this one doesn't seem to send the sync either because it returns if $self->{net}->version == 1. Interestingly, XKoreProxy->version returns 1.

I'm wondering if that's a bug?

[EternalHarvest]

Could be, is there any problems related to it?

[Empyrium]

I fear it could be possible to detect OpenKore since there are no syncs coming from the client.

[EternalHarvest]

Looks like it was like that from the start:

http://openkore.svn.sourceforge.net/vie ... 41&r2=5447
http://openkore.svn.sourceforge.net/vie ... 47&r2=5460

At that revision, version() == 1:
http://openkore.svn.sourceforge.net/vie ... iew=markup
and sendSync wasn't sending anything when version() == 1:
http://openkore.svn.sourceforge.net/vie ... threv=5460

So far, I have no idea how that r5460 "Fix ropp support" worked.

Needs fixing if it really doesn't send sync.