modified processAutoStorage

[DrKN]

I have added the new config setting - storageAuto_useItem
as some cash item like storage box and this will help
and also i have deleted sendStart and getStart as storageAuto and getAuto should be always happened when storage is opened
Also i have added to check $storage{opened} instead of the previous condition to gain advantage on using storage box but not closing it to get/put while OK is attacking or routing or something in that map.

I put in pastebin to have the perl syntax when viewing it


http://pastebin.com/0EQARPqe

**a mistake there: missing a closing bracket
** added delete $storage{opened}; into sub initMapChangeVars

[EternalHarvest]

Stuff with storageAuto_useItem looks fine.

Code: Select all

$args->{done} = 1

This (and some other lines with $args->{done}) is deleted too?

Code: Select all

-	Plugins::callHook("AI_storage_done", \%hookArgs);
-	undef $args->{done} if ($hookArgs{return});
+	Plugins::callHook("AI_storage_done");

Why?

Also, "People can quickly inspect and understand your modifications and provide more intelligent feedback." if you post a diff.

[DrKN]

Stuff with storageAuto_useItem looks fine.

Code: Select all

$args->{done} = 1

This (and some other lines with $args->{done}) is deleted too?

Code: Select all

-	Plugins::callHook("AI_storage_done", \%hookArgs);
-	undef $args->{done} if ($hookArgs{return});
+	Plugins::callHook("AI_storage_done");

Why?

Also, "People can quickly inspect and understand your modifications and provide more intelligent feedback." if you post a diff.

Plugins::callHook("AI_storage_done", \%hookArgs); is deleted because hookArgs is blank when calling the hook so i changed it into no argv
$args->{done} seems no much meaning here? or i have misunderstanding the code...?
theres a issue rite now... after using the storage box it will keep standing if there is a monster attacking YOU

i want to post a diff but how should i do..?
posting the code in forum or... somewhere able to do a diff upload?

[EternalHarvest]

Plugins::callHook("AI_storage_done", \%hookArgs); is deleted because hookArgs is blank when calling the hook so i changed it into no argv

Code: Select all

# plugins can hook here and decide to keep storage open longer

Hook handler can write to hookArgs and this is checked right in the next line.

$args->{done} seems no much meaning here? or i have misunderstanding the code...?

It seems to be the flag indicating whether storaging is finished or not.

i want to post a diff but how should i do..?
posting the code in forum or... somewhere able to do a diff upload?

Post in forum post or pastebin, it's all text anyway.