Fix for Bad Naming on Starcrumb Count

This place is for Closed bug reports only. NOT for asking help!

Moderators: Moderators, Developers

Fr3DBr
Developers
Developers
Posts: 60
Joined: 05 Oct 2011, 09:21
Noob?: No
Location: Brazil

Fix for Bad Naming on Starcrumb Count

#1 Post by Fr3DBr »

Hello,

Sometimes we see items with name VVVVVVVVVVVS or VVVVVVVVVVVVVVVVVVVVVVVVVVVVVVVVVVVVVS but we already know the maximum limit of star crumbs are 3 for neutral weapons.

So based on this i made a quick fix which makes the stuff work normally again, here we go :

In Misc.pm Find :

Code: Select all

	} elsif ($cards[0] == 255) {
		# Forged weapon
		#
		# Display e.g. "VVS Earth" or "Fire"
		my $elementID = $cards[1] % 10;
		my $elementName = $elements_lut{$elementID};
		my $starCrumbs = ($cards[1] >> 8) / 5;
		$prefix .= ('V'x$starCrumbs)."S " if $starCrumbs;
		$prefix .= "$elementName " if ($elementName ne "");
		$suffix = "$elementName" if ($elementName ne "");
        }
And change it to :

Code: Select all

	} elsif ($cards[0] == 255) {
		# Forged weapon
		#
		# Display e.g. "VVS Earth" or "Fire"
		my $elementID = $cards[1] % 10;
		my $elementName = $elements_lut{$elementID};
		my $starCrumbs = ($cards[1] >> 8) / 5;
		if ( $starCrumbs <= 3 )
		{
			$prefix .= ('V'x$starCrumbs)."S " if $starCrumbs;
			$prefix .= "$elementName " if ($elementName ne "");
			$suffix = "$elementName" if ($elementName ne "");
		}
        }
Have fun ;)