processItemsAutoGather and pickupitems.txt

[sofax222]

I trace the processItemsAutoGather in src/AI/CoreLogic.pm.

I found some thing:
When some item is set 2 in pickupitems.txt file.
It is same as setting 1.
Another words, the setting 2 in pickupitems.txt file has not "to take the item as fast as it can" effect !
Am I right ??

PS: The "to take the item as fast as it can" is the description in pickupitems.txt file.

[EternalHarvest]

Code: Select all

$ grep -r pickupitems . |grep 2
./Network/Receive/ServerType0.pm:	if ($AI == AI::AUTO && pickupitems(lc($item->{name})) == 2
./Network/Receive/kRO/Sakexe_0.pm:	if ($AI == AI::AUTO && pickupitems(lc($item->{name})) == 2

Code: Select all

	# Take item as fast as possible
	if ($AI == AI::AUTO && pickupitems(lc($item->{name})) == 2
	 && ($config{'itemsTakeAuto'} || $config{'itemsGatherAuto'})
	 && (percent_weight($char) < $config{'itemsMaxWeight'})
	 && distance($item->{pos}, $char->{pos_to}) <= 5) {
		$messageSender->sendTake($args->{ID});
	}

It's not good that this piece of logic is in the Network module, but there it is.