bRO sync ex packets

Wrote new code? Fixed a bug? Want to discuss technical stuff? Feel free to post it here.

Moderator: Moderators

uPantcho
Human
Human
Posts: 42
Joined: 05 Nov 2009, 05:25
Noob?: Yes

bRO sync ex packets

#1 Post by uPantcho »

the current revision (7978) have some wrong packets

specifically, these packets are wrong:

Code: Select all

'0910' => ['sync_request_ex_2'],
'0911' => ['sync_request_ex_2'],
'0912' => ['sync_request_ex_2'],
'0913' => ['sync_request_ex_2'],
'0914' => ['sync_request_ex_2'],
'090F' => ['sync_request_ex_2'],
'0915' => ['sync_request_ex_2'],
'0916' => ['sync_request_ex_2'],
they dont even have the same length as the other sync ex packets:

Code: Select all

0910 10 10 1
0911 30 30 1
0912 10 10 1
0913 30 30 1
0914 -1 79 1
090F -1 72 1
0915 -1 73 1
0916 26 26 1

#sync ex packets
089D 2 2 0
093A 2 2 0
0950 2 2 0
0932 2 2 0
0860 2 2 0
0920 2 2 0

and these are missing:

Code: Select all

		'0952' => '085E',
		'0958' => '0966',
		'0961' => '0964',
		'0896' => '0931',
		'0934' => '0939',
		'0364' => '085C',
		'0949' => '08A2',
		'08A9' => '035F',
		'0861' => '0437',
basically the packets used in sync ex 2 are now 6 lines after the usual location

also, why there are 2 different functions doing the same thing? sync_request_ex_1 and sync_request_ex_2

of course, they are handling different packets but isnt simpler just put every packet on the same method?