Req: Bug reports - show us how you *crash* openkore.

Discussion about everything RO and OpenKore related. This place is NOT for ANY kind of support questions.

Moderator: Moderators

User avatar
ChrstphrR
Testers Team
Testers Team
Posts: 42
Joined: 09 May 2010, 17:30
Noob?: No
Location: Northern Alberta, Canada

Req: Bug reports - show us how you *crash* openkore.

#1 Post by ChrstphrR »

I just posted a fix to SVN earlier today, that fixed a bug that had persisted for up to SEVEN AND A HALF YEARS in openkore, that would coredump and crash kore from a user-executed command on the console.

See: http://forums.openkore.com/viewtopic.php?f=36&t=18450

This is simply unexcusable; both that such a bug persisted for ninety (90) months unpatched, and that none of the thousands of kore users brought up the problem sooner, so that it could be patched by a developer.

If I can stumble upon a crashable bug so easily, then surely there are many more the rest of you have found.

And, if they're triggered by a command a user types and executes, they're normally much easier to narrow down and patch up.


It's fun too, trying to make a command crash the whole program. Okay, it's annoying as hell when your bot won't work 'cause a simple command crashed it.

Take the 5-10 minutes to report the problem, so it can be fixed instead of wearing down your patience. No user-entered command should EVER crash kore. Let's give kore a good shakedown so that it's more stable for you, and everyone.

I'll bet that the rest of you can find 6 crashes before I find another one myself. Beat me to finding a bug that crashes core... and we all win for the effort.


Please do not put bug reports in this thread, make up a clear post in the Bug Reports sub-forum.
  • List the revision you're using in the thread title. A title like "r8320: Crash with 'foo' command" will help grab our attention. (Use "version" in the console of kore, and state the (r####) revision number it outputs)
  • Describe in a simple set of steps what you did to cause the crash. Can you repeat your steps, and get the same crash? Repeatable steps help make it easier for a Tester to check the problem, and/or a Developer to code a fix for it.
  • Check if you have an errors.txt generated from your crash -- paste it in, and surround it with a "code" or "quote" block tags. All that gibberish in there helps the Devs figure out what part of the code caused the error, right down to the line numbers.
  • Remember to do that "version" command in kore, and state in the title which revision number you're using. Seriously now, it makes the errors.txt make sense to the other Developers.
EternalHarvest
Developers
Developers
Posts: 1798
Joined: 05 Dec 2008, 05:42
Noob?: Yes

Re: Req: Bug reports - show us how you *crash* openkore.

#2 Post by EternalHarvest »

It's true that no command should lead to a crash.

Maybe it persisted because it's kind of unique case? XKore proxy probably isn't widely used, as well as "ai clear" before being connected to a server (I suspect it would be fine if you're connected at least once and then disconnected).

Also it's a crash from relatively recently added assert which helps with catching possible bugs. Maybe it wasn't really a problem by itself.