StellaRO | 2.0.6.1 | Could not identify item

[gknight]

I am using a bs in StellaRO. When I tried to identify items while botting, there are no item listed in the identify list although there are unidentified items in my inventory. The type of item for weapon and armour are also wrongly stated. Knife has been recognized as armour. I tried changing the server type from 8_1 to 8_4 as server encoding is korean. I checked the items description in the table folder and there is no problem about that.

This is stated in my console log on the equipment that are not equipped:
-- Equipment (Not Equipped) --
10 Sunglasses (Weapon)
15 Indian Fillet (Weapon) -- Not Identified
16 Wand [3] (Armour) -- Not Identified
17 Annoyed Mask (Weapon) -- Not Identified
18 Poker Face (Weapon) -- Not Identified

This is stated in my console log when i type the console command identify:
---------Identify List--------
------------------------------

But if I used identify skill before typing identify command, it can detect the unidentified item. However, after I identify one item, the problem appear again.

Received Possible Identify List (5 item(s)) - type 'identify'
Unable to cast skill Item Appraisal in 3 tries.
You are sitting.
---------Identify List--------
0 Indian Fillet
1 Wand [3]
2 Poker Face
3 Annoyed Mask
4 Wand [3]
------------------------------
Item Identified: Indian Fillet (8)
Error in function 'identify' (Identify Item)
Identify Item 1 does not exist
---------Identify List--------
------------------------------

If I repeat the step typing identify after using the skill identify for 2-3 times, the bot will keep repeating sitting and standing, unless I type ai clear. I do not understand why the bot acted this way.

[sli]

The identify thing might be a bug, but the equipment type thing can't really be fixed. Weirdness with the RO protocol.

[Technology]

the equipment type thing can't really be fixed. Weirdness with the RO protocol.

I'm not sure, but doesn't a server specifical itemtypes.txt fix that issue?


The identify list however seems to be acting like intended, the @identifyID (the list) just gets undefined:
- after each mapchange (see sub initMapChangeVars)
- after each item identify
- before retreiving the identify_list

Therefor, you need to re-use the identify skill before you use the identify command, as you would do ingame.

should the %repairList also be undefined after a mapchange?
(because that isn't the case atm)

foolproof patch for identify command:

Code: Select all

Index: Commands.pm
===================================================================
--- Commands.pm	(revision 6583)
+++ Commands.pm	(working copy)
@@ -2581,7 +2581,7 @@
 		return;
 	}
 	my (undef, $arg1) = @_;
-	if ($arg1 eq "") {
+	if ($arg1 eq "" && defined @identifyID) {
 		message T("---------Identify List--------\n"), "list";
 		for (my $i = 0; $i < @identifyID; $i++) {
 			next if ($identifyID[$i] eq "");
@@ -2591,7 +2591,8 @@
 				"list");
 		}
 		message("------------------------------\n", "list");
-
+	} elsif (!defined @identifyID) {
+		error TF("The identify list is empty, please use the identify skill or a magnifier first.\n");
 	} elsif ($arg1 =~ /^\d+$/) {
 		if ($identifyID[$arg1] eq "") {
 			error TF("Error in function 'identify' (Identify Item)\n" .

undefining %repairList upon mapchange:

Code: Select all

Index: functions.pl
===================================================================
--- functions.pl	(revision 6583)
+++ functions.pl	(working copy)
@@ -453,6 +453,7 @@
 	undef @currentChatRoomUsers;
 	undef @itemsID;
 	undef @identifyID;
+	undef %repairList;
 	undef @spellsID;
 	undef @arrowCraftID;
 	undef %items;