skillsstatus update proposal

[EternalHarvest]

skillsstatus.txt seems to be missing many statuses (and they can be useful in some situations). Should we update it? (internal status names by kLabMouse)

1. I understand that due to compatibility purposes, it's better not to change existing status names, but these may be out of sense:

Code: Select all

<id> <current skillstatus name> - <internal name> <proposed name>
77 Sleeping - SERVICEFORYOU At Your Service
100 Night - SIEGEMODE
241 Steamed Tongue - EFST_FOOD_STR
242 Steamed Scorpion - EFST_FOOD_AGI
243 Stew Of Immortality - EFST_FOOD_VIT
244 Hwergelmir's Tonic - EFST_FOOD_DEX
245 Dragon Breath Cocktail - EFST_FOOD_INT
246 Cooked Nine Tail's Tails - EFST_FOOD_LUK

2. These are missing in current skillstatus. I proposed some names, following OpenKore's skill names.

Code: Select all

<id> <internal name> <proposed name>
40 ATTHASTE_INFINITY ASPD Up
43 AUTOCOUNTER Auto Counter
44 SPLASHER Splasher
45 ANKLESNARE Ankle Snare
46 POSTDELAY
47 NOACTION
48 IMPOSSIBLEPICKUP
63 MAGICROD Magic Rod
66 SPECIALZONE
69 BDPLAYING
70 WHISTLE Whistle
71 ASSASSINCROSS Assassin Cross at Sunset
72 POEMBRAGI Bragi's Poem
73 APPLEIDUN Idun's Apple
74 HUMMING Humming
75 DONTFORGETME Forget Me Not
76 FORTUNEKISS Fortune's Kiss
78 RICHMANKIM Rich Man Mr.Kim
79 ETERNALCHAOS Eternal Chaos
80 DRUMBATTLEFIELD Drum Sound on Battlefield
81 RINGNIBELUNGEN Ring of Nibelungen
82 ROKISWEIL Roki's Weil
83 INTOABYSS Into Abyss
84 SIEGFRIED Invulnerable Siegfried
85 BLADESTOP Blade Stop
88 EXPLOSIONSPIRITS Vigor Explosion
94 MAGICATTACK
96 WEAPONBRAKER
97 PROPERTYUNDEAD Undead
98 POWERUP Power Up
99 AGIUP AGI Up
101 INVISIBLE Invisible
102 STATUSONE
126 MINDBREAKER Mind Breaker
128 FOGWALL Wall of Fog
129 SPIDERWEB Spider Web
136 STORMKICK_READY Ready Storm Delay
138 DOWNKICK_READY Ready Down Delay
140 TURNKICK_READY Ready Turn Delay
142 COUNTER_READY Ready Counter Delay
144 DODGE_READY TK Dodge Delay
154 SWOO Eswoo
155 STAR2
162 FRIEND
163 FRIENDUP
164 SG_WARM Warmth
166 SG_MOON_WARM Warmth of Moon
167 SG_STAR_WARM Warmth of Star
168 EMOTION
172 EXPUP Exp Up
173 GDSKILL_BATTLEORDER Battle Orders
174 GDSKILL_REGENERATION Regeneration
175 GDSKILL_POSTDELAY Guild Delay
176 RESISTHANDICAP
177 MAXHPPERCENT
178 MAXSPPERCENT
179 DEFENCE
180 SLOWDOWN
183 NOT_EXTREMITYFIST
187 GRAVITATION Gravity Field
189 LONGING Longing for Freedom
190 HERMODE Wand of Hermod
191 TAROTCARD Tarot Card of Fate
192 HLIF_AVOID Urgent Escape
193 HFLI_FLEET Flitting
194 HFLI_SPEED Accelerated Flight
195 HLIF_CHANGE Mental Change
196 HAMI_BLOODLUST Blood Lust
202 DISABLEMOVE
211 NJ_SUITON Suiton
212 PET
213 MENTAL
214 EXPMEMORY
215 PERFORMANCE
216 GAIN
217 GRIFFON
218 DRIFT
219 WALLSHIFT
220 REINCARNATION
221 PATTACK
222 PSPEED
223 PDEFENCE
224 PCRITICAL
225 RANKING
226 PRTIPLE
227 DENERGY
228 WAVE1
229 WAVE2
230 WAVE3
231 WAVE4
232 DAURA
233 DFREEZER
234 DPUNISH
235 DBARRIER
236 DWARNING
237 MOUSEWHEEL
238 DGAUGE
239 DACCEL
240 DBLOCK
249 CRITICALSUCCESSVALUE
254 DA_ENERGY
255 DA_FIRSTSLOT
256 DA_HEADDEF
257 DA_SPACE
258 DA_TRANSFORM
259 DA_ITEMREBUILD
260 DA_ILLUSION
261 DA_DARKPOWER
262 DA_EARPLUG
263 DA_CONTRACT
264 DA_BLACK
265 DA_MAGICCART
266 CRYSTAL
267 DA_REBUILD
268 DA_EDARKNESS
269 DA_EGUARDIAN
270 DA_TIMEOUT
271 FOOD_STR_CASH Steamed Tongue
272 FOOD_AGI_CASH Steamed Scorpion
273 FOOD_VIT_CASH Stew Of Immortality
274 FOOD_DEX_CASH Hwergelmir's Tonic
275 FOOD_INT_CASH Dragon Breath Cocktail
276 FOOD_LUK_CASH Cooked Nine Tail's Tails
277 MER_FLEE Flee Up
278 MER_ATK Atk Up
279 MER_HP HP Up
280 MER_SP SP Up
281 MER_HIT Hit Up
282 SLOWCAST
283 MAGICMIRROR Magic Mirror
284 STONESKIN Stone Skin
285 ANTIMAGIC Anti Magic
287 NPC_DEFENDER
288 NOACTION_WAIT
289 MOVHASTE_HORSE
290 PROTECT_DEF
291 PROTECT_MDEF
292 HEALPLUS
293 S_LIFEPOTION
294 L_LIFEPOTION
295 CRITICALPERCENT
296 PLUSAVOIDVALUE
297 ATKER_ASPD
298 TARGET_ASPD
299 ATKER_MOVESPEED
300 ATKER_BLOOD
301 TARGET_BLOOD
302 ARMOR_PROPERTY
303 REUSE_LIMIT_A
304 HELLPOWER Hell Power
305 STEAMPACK
306 REUSE_LIMIT_B
307 REUSE_LIMIT_C
308 REUSE_LIMIT_D
309 REUSE_LIMIT_E
310 REUSE_LIMIT_F
311 INVINCIBLE Invincible
312 CASH_PLUSONLYJOBEXP
313 PARTYFLEE
314 ANGEL_PROTECT

Need corrections and proposals for status names (based on something in-game?).
Also, this can be added to skillsstatus.txt to realize what some names mean.

[kali]

I agree with the changes.

Since it's gonna be a new version, I guess it's okay to sacrifice backwards compatibility. Let's just put the disclaimers in the readme - and let those botters who just leech (and never learn how to config) suffer because of their inability to read and think.

[h4rry84]

I agree with the changes.

Since it's gonna be a new version, I guess it's okay to sacrifice backwards compatibility. Let's just put the disclaimers in the readme - and let those botters who just leech (and never learn how to config) suffer because of their inability to read and think.

Agreed with Evil Kali version

[kLabMouse]

I Agree too.
Anyway, Statuses are a little bit old.

[EternalHarvest]

What about skill names in general, then?

Code: Select all

Drum Sound on Battlefield
Forget Me Not
Ready Storm/Down/Turn/Counter, TK Dodge, HP/SP Time
Power
Feel, Hate, Devil, Friend
Soul Linker's Links
Sma, Swoo, Ske, Ska
Adjustment, Aiming
... etc ...

Are these from some official server?

[h4rry84]

it's better to get the name from official files inside *.grf

[Technology]

We could get the internal names from the client and make that a table file with contents: ID INTERNALNAME
Then, we can make another table file based on that where we put: ID realname

Then we parse first the first table file and put the contents in an array
Then we parse the second table file and override the first array for array indexes (ID's) where a realname is specified.

Or we could maintain compatibility for both INTERNALNAME and ourname by +/- mimicing the actorList that we use for actors. (which is basically an class that holds objects of other classes)
The only change would be $self->{IDmap} = []; (key: ID, holds: object) (array instead of hash)
then we can do: $object = $objectList->getByID($ID)
then we can do: $object->internalname() or $object->realname()
and so on ...
But what if lets say, you wanted to get the ID from the name? Then you need yet another property $self->{realnameMap} = {}; (key: name, holds: ID) and idem for an internalnameMap

Or with tied hashes.

Or it might be more effective to add support for dblite and make sql tables from our txt tables that we can query on.