r6859 | openkore doesn't always "see" party members' HP

[865255]

To reproduce:

1. setup an acolyte class bot (aco, priest, champ, etc) that has Heal skill.
2. add this skill block:

Code: Select all

partySkill Heal {
	lvl 10
	target_hp < 90%
}

3. make a party, and invite the bot
4. relog the bot, and it will start spamming level 1 Heal on party members.
5. if you type 'party' in the console, you'll see what the bot sees:
- it sees the party members (sees them as "online" correctly),
- it sees their map and coordinates correctly,
- but it doesn't see their HP yet.
6. the bot will keep spamming heal on those party member(s) until it gets an update on their HP
(one way is to take damage from a monster. Then the bot receives your updated HP and it'll Heal you properly, then stop spamming)

[Technology]

nice bug report, i'll look at this again once i finish another project.

Maybe we should do this:

Code: Select all

Index: Misc.pm
===================================================================
--- Misc.pm	(revision 6858)
+++ Misc.pm	(working copy)
@@ -3240,7 +3240,7 @@
 sub percent_hp {
 	my $r_hash = shift;
 	if (!$$r_hash{'hp_max'}) {
-		return 0;
+		return undef;
 	} else {
 		return ($$r_hash{'hp'} / $$r_hash{'hp_max'} * 100);
 	}

Otherwise we make kore think that the other char has 0 hp while it actually hasn't been received by kore.
So if we have target_hp < 80% it would still heal because of this.

[Technology]

Please test the last svn to see if it is fixed now.

[865255]

Yes, that fixed it.

Thanks

[kLabMouse]

Bug Closed.