r6914 | TaeKwon Mission Skill

[midnytblu]

using the TaeKwon Mission skill results in a garbled message where it's supposed to display the current monster mission.



works well on 2.0.6.1.

EDIT:
current mission in-game is Aster.

[kali]

Thanks midnytblue, what's the svn revision number?

If you have tortoise svn you can right click on the versioned openkore folder and get it from one of the menus there.

[midnytblu]

hello sir kali,

i got r6914. i'll change the topic title.

[kali]

Thanks

If you wanna make a stab at resolving the bug, try this:
Revert to the previous revision one rev at a time, and find out which revision has it working, and which revision immediately after is causing the bug. Odds are, the changes between those revisions caused the regression.

I know this might take some time, but doing so will help nail down the exact problem

[midnytblu]

^this is actually the first time i used my ranker on SVN. not sure if the bug was already present beforehand but i'll give it a shot as you suggested.

/no1

[Technology]

It happened in revision 6840 i believe.

It has something todo with the change from:

Code: Select all

'020E' => ['taekwon_mission_receive', 'Z24 a4 c1', [qw(monName ID value)]],

sub taekwon_mission_receive {
	 my ($self, $args) = @_;
	message T("TaeKwon Mission : ".$args->{monName}."(".$args->{value}."\%)"."\n"), "info";
} 

to the more advanced:

Code: Select all

'020E' => ['teakwon_packets', 'Z24 a4 C2', [qw(name ID value flag)]],

# TODO test if we must use ID to know if the packets are meant for us.
sub teakwon_packets {
	my ($self, $args) = @_;
	if ($args->{flag} == 0) {
		# Info about Star Gladiator save map: Map registered
		my $string = ($args->{value} == 1) ? "Sun" : ($args->{value} == 2) ? "Moon" : ($args->{value} == 3) ? "Stars" : "unknown";
		message TF("You have now marked: %s as Place of the %s.\n", $args->{name}, $string), "info";
	} elsif ($args->{flag} == 1) {
		# Info about Star Gladiator save map: Information
		my $string = ($args->{value} == 1) ? "Sun" : ($args->{value} == 2) ? "Moon" : ($args->{value} == 3) ? "Stars" : "unknown";
		message TF("%s is marked as Place of the %s.\n", $args->{name}, $string), "info";
	} elsif ($args->{flag} == 10) {
		# Info about Star Gladiator hate mob: Register mob
		my $string = ($args->{value} == 1) ? "Sun" : ($args->{value} == 2) ? "Moon" : ($args->{value} == 3) ? "Stars" : "unknown";
		message TF("You have now marked %s as Target of the %s.\n", $args->{name}, $string), "info";
	} elsif ($args->{flag} == 11) {
		# Info about Star Gladiator hate mob: Information
		my $string = ($args->{value} == 1) ? "Sun" : ($args->{value} == 2) ? "Moon" : ($args->{value} == 3) ? "Stars" : "unknown";
		message TF("%s is marked as Target of the %s.\n", $args->{name}, $string);
	} elsif ($args->{flag} == 20) {
		#Info about TaeKwon Do TK_MISSION mob
		message TF("TaeKwon Mission : %s (%)"."\n", monsterName($args->{ID}), $args->{value}), "info";
	} elsif ($args->{flag} == 30) {
		#Feel/Hate reset
		message T("Your Hate and Feel targets have been resetted.\n"), "info";
	} else {
		warning TF("flag: %s gave unknown results in: %s\n", $args->{flag}, $self->{packet_list}{$args->{switch}}->[0]);
	}
}

I'm in class now so don't have access to stuff
The length of the packet seems to be 32 so thats right. (2+24+4+2)
the diff

try changing:

Code: Select all

message TF("TaeKwon Mission : %s (%)"."\n", monsterName($args->{ID}), $args->{value}), "info";

to

Code: Select all

message TF("TaeKwon Mission: %s (%)\n", $args->{name}, $args->{value}), "info";

(the cause might be the concatination but probably its monsterName($args->{ID}) )

eA's code however shows (note the mob_id):

Code: Select all

void clif_mission_info(struct map_session_data *sd, int mob_id, unsigned char progress)
{
	int fd=sd->fd;
	WFIFOHEAD(fd,packet_len(0x20e));
	WFIFOW(fd,0)=0x20e;
	strncpy((char*)WFIFOP(fd,2),mob_db(mob_id)->jname, NAME_LENGTH);
	WFIFOL(fd,26)=mob_id;
	WFIFOB(fd,30)=progress; //Message to display
	WFIFOB(fd,31)=20;
	WFIFOSET(fd, packet_len(0x20e));
}

[kLabMouse]

Anybody noticed that Kore say "Unknown NPC" ?

[midnytblu]

^i just logged on when i took the screenshot. don't mind that

[midnytblu]

@Technology
sorry but where can i find this?

try changing:

Code: Select all

message TF("TaeKwon Mission : %s (%)"."\n", monsterName($args->{ID}), $args->{value}), "info";

to

Code: Select all

message TF("TaeKwon Mission: %s (%)\n", $args->{name}, $args->{value}), "info";

(the cause might be the concatination but probably its monsterName($args->{ID}) )

i checked Receive.pm but this line is not present.
thanks.

[Technology]

src\Network\Receive\ServerType0.pm