r6918 | party show picker

[help_us]

Code: Select all

OpenKore version what-will-become-2.1 (SVN Version) 
@ai_seq = take items_take follow
Network state = 5
Network handler = Network::DirectConnection
SVN revision: 6918
No loaded plugins.

Error message:
Can't call method "name" on unblessed reference at src/Network/Receive/ServerType0.pm line 7151.

Stack trace:
Can't call method "name" on unblessed reference at src/Network/Receive/ServerType0.pm line 7151.
 at src/Network/Receive/ServerType0.pm line 7151
	Network::Receive::ServerType0::party_show_picker('Network::Receive::ServerType22=HASH(0x37cb8c4)', 'HASH(0x2ea0044)') called at src/Network/Receive.pm line 170
	Network::Receive::parse('Network::Receive::ServerType22=HASH(0x37cb8c4)', '\x{b8}\x{2}\x{fe}\x{b3}\x{3}\x{0}\x{9f}\x{8}\x{0}\x{0}\x{0}\x{0}\x{0}\x{0}\x{0}\x{0}\x{0}\x{0}\x{0}\x{0}\x{1}\x{4}') called at src/functions.pl line 1205
	main::parseIncomingMessage('\x{b8}\x{2}\x{fe}\x{b3}\x{3}\x{0}\x{9f}\x{8}\x{0}\x{0}\x{0}\x{0}\x{0}\x{0}\x{0}\x{0}\x{0}\x{0}\x{0}\x{0}\x{1}\x{4}') called at src/functions.pl line 552
	main::mainLoop_initialized() called at src/functions.pl line 70
	main::mainLoop() called at src/Interface.pm line 75
	Interface::mainLoop('Interface::Console::Win32=HASH(0x2955cd4)') called at openkore.pl line 96
	main::__start() called at start.pl line 125

Died at this line:
  	$item->{broken} = $args->{broken};
* 	message TF("Party member %s has gained item %s.\n", $player->name(), itemName($item)), "info";
  }

idk what was happen that time, but it happen to my bot today

[Technology]

Looks a lot like yet another autovivication bug.
We should have safer methods to get actors from their ID's and to check if the actor with ID exists.

discussion about stopping these bugs

[EternalHarvest]

Tried to fix some autovivification.

Have not touched this line, in which case it is needed?

Code: Select all

sub party_join {
...
$char->{party}{users}{$ID} = new Actor::Party if ($char->{party}{users}{$ID}{name});

[kLabMouse]

Fixed in r7009.
Closed.