r7250 | version command not showing correct version!

This place is for Closed bug reports only. NOT for asking help!

Moderators: Moderators, Developers

User avatar
lolzorbot
Noob
Noob
Posts: 18
Joined: 28 Apr 2010, 16:20
Noob?: No

r7250 | version command not showing correct version!

#1 Post by lolzorbot »

when typing the command "version" and pressing enter it comes with the following
*** OpenKore what-will-become-2.1 (SVN Version) - Custom RagnarokOnline client ***
*** http://www.openkore.com/ ***
not quite the r7250 that i was expecting (and running on)
Technology
Super Moderators
Super Moderators
Posts: 801
Joined: 06 May 2008, 12:47
Noob?: No

Re: r7250 | version command not showing correct version!

#2 Post by Technology »

Yea and the notion of 'SVN Version' is also confusing for the users.
Maybe we can do something like this:

Code: Select all

Index: src/Settings.pm
===================================================================
--- src/Settings.pm	(revision 7312)
+++ src/Settings.pm	(working copy)
@@ -77,10 +77,10 @@
 our $NAME = 'OpenKore';
 our $VERSION = 'what-will-become-2.1';
 # Translation Comment: Version String
-our $SVN = T(" (SVN Version) ");
+#our $SVN = T(" (SVN Version) ");
 our $WEBSITE = 'http://www.openkore.com/';
 # Translation Comment: Version String
-our $versionText = "*** $NAME ${VERSION}${SVN} - " . T("Custom Ragnarok Online client") . " ***\n***   $WEBSITE   ***\n";
+our $versionText = "*** $NAME ${VERSION} ( r" . (getSVNRevision() || '?') . ' ) - ' . T("Custom Ragnarok Online client") . " ***\n***   $WEBSITE   ***\n";
 our $welcomeText = TF("Welcome to %s.", $NAME);
 
 
Suggestions are welcome...
One ST0 to rule them all? One PE viewer to find them!
One ST_kRO to bring them all and in the darkness bind them...

Mount Doom awaits us, fellowship of OpenKore!
User avatar
kLabMouse
Administrator
Administrator
Posts: 1301
Joined: 24 Apr 2008, 12:02

Re: r7250 | version command not showing correct version!

#3 Post by kLabMouse »

Technology
Please commit.
Technology
Super Moderators
Super Moderators
Posts: 801
Joined: 06 May 2008, 12:47
Noob?: No

Re: r7250 | version command not showing correct version!

#4 Post by Technology »

done.
One ST0 to rule them all? One PE viewer to find them!
One ST_kRO to bring them all and in the darkness bind them...

Mount Doom awaits us, fellowship of OpenKore!