rev7258| Creating new config instanted of replacing old one

Forum closed. All further discussion to be discussed at https://github.com/OpenKore/

Moderators: Moderators, Developers

Mushroom
Perl Monk
Perl Monk
Posts: 427
Joined: 04 Apr 2008, 14:04
Noob?: No
Location: Brazil

rev7258| Creating new config instanted of replacing old one

#1 Post by Mushroom »

Assuming we have 2 config files, the main one and the one which is included on the main. When I try to change a value from a config in the included file (using command conf), Openkore creates a new config key with the defined value in the main file instanted of replacing the values on the included files.

Example, before changing anything
fileA.txt
!include fileB.txt
apple 1
banana 2

fileB.txt
grape 3
orange 4
After changing config grape using 'conf grape 0'
fileA.txt
!include fileB.txt
apple 1
banana 2
grape 0

fileB.txt
grape 3
orange 4
It just breaks the whole concept of being organized lol
Quit.
User avatar
kLabMouse
Administrator
Administrator
Posts: 1301
Joined: 24 Apr 2008, 12:02

Re: rev7258| Creating new config instanted of replacing old one

#2 Post by kLabMouse »

Nope.
the Included Conf parts are used to be static.
but the main one is dynamic, and could be changed.
that is done specially, because multiple instances could use included files, but the main one is uniq for every running instance.
EternalHarvest
Developers
Developers
Posts: 1798
Joined: 05 Dec 2008, 05:42
Noob?: Yes

Re: rev7258| Creating new config instanted of replacing old one

#3 Post by EternalHarvest »

I think there should be !include syntax to choose preferred behavior.
rocknroll
Been there done that!
Been there done that!
Posts: 118
Joined: 19 Sep 2011, 07:30
Noob?: Yes

Re: rev7258| Creating new config instanted of replacing old one

#4 Post by rocknroll »

This is very very helpfully for me :mrgreen:
now i just create one config for all, tq sir ^^
Sorry, my english is very bad !